turbaszek commented on a change in pull request #14276:
URL: https://github.com/apache/airflow/pull/14276#discussion_r578020864
##########
File path: airflow/providers/google/cloud/transfers/gdrive_to_gcs.py
##########
@@ -85,38 +92,14 @@ def __init__(
**kwargs,
) -> None:
super().__init__(**kwargs)
- self.destination_bucket = destination_bucket
- self.destination_object = destination_object
+ self.bucket_name = destination_bucket or bucket_name
+ self.object_name = destination_object or object_name
Review comment:
```suggestion
self.bucket_name = destination_bucket or bucket_name
if destination_bucket:
warnings.warn("`destination_bucket ` is deprecated please use
`bucket_name`", DeprecationWarning)
bucket_name = destination_bucket
self.bucket_name = bucket_name
```
In this way users will get DeprecationWarning in runtime, WDYT? Probably we
should do the same for `object_name`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
