ephraimbuddy commented on a change in pull request #14306:
URL: https://github.com/apache/airflow/pull/14306#discussion_r579157675



##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -2639,6 +2644,16 @@ components:
       required: true
       description: The variable Key.
 
+    # DAGs
+    OnlyActive:
+      in: query
+      name: only_active
+      schema:
+        type: boolean
+      required: false
+      description: |
+        Only return DAGs which were seen on the last DagBag load.
+

Review comment:
       ```suggestion
   
   ```

##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -377,6 +377,7 @@ paths:
       parameters:
         - $ref: '#/components/parameters/PageLimit'
         - $ref: '#/components/parameters/PageOffset'
+        - $ref: '#/components/parameters/OnlyActive'

Review comment:
       ```suggestion
          - name: only_active
             in: query
             schema:
               type: boolean
             required: false
             description: Only return DAGs which were seen on the last DagBag 
load.
   ```
   Since `OnlyActive` is only used in this endpoint, It makes sense to have the 
parameters here instead of creating a component for it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to