turbaszek commented on a change in pull request #14280:
URL: https://github.com/apache/airflow/pull/14280#discussion_r579612349
##########
File path: airflow/plugins_manager.py
##########
@@ -427,3 +427,39 @@ def integrate_macros_plugins() -> None:
# Register the newly created module on airflow.macros such that it
# can be accessed when rendering templates.
setattr(macros, plugin.name, macros_module)
+
+
+def get_plugin_info(attrs_to_dump: Optional[List[str]] = None):
+ """
+ Dump plugins attributes
+
+ :param attrs_to_dump: A list of plugin attributes to dump
+ :type attrs_to_dump: List
+ """
+ plugins_attributes_to_dump = [
+ "hooks",
+ "executors",
+ "macros",
+ "admin_views",
+ "flask_blueprints",
+ "menu_links",
+ "appbuilder_views",
+ "appbuilder_menu_items",
+ "global_operator_extra_links",
+ "operator_extra_links",
+ "source",
+ ]
Review comment:
How about moving this value outside of the function as a constant? Then
we can use it as default, WDYT? Also a nit, but should we change it to be a
`set` instead of `list`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
