ephraimbuddy commented on a change in pull request #14254: URL: https://github.com/apache/airflow/pull/14254#discussion_r579713000
########## File path: tests/providers/microsoft/azure/transfers/test_sftp_to_wasb_system.py ########## @@ -0,0 +1,50 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +import os + +import pytest + +from airflow.providers.microsoft.azure.example_dags.example_sftp_to_wasb import SFTP_SRC_PATH +from tests.test_utils.azure_system_helpers import ( + AZURE_DAG_FOLDER, + AzureSystemTest, + provide_wasb_default_connection, +) + +CREDENTIALS_DIR = os.environ.get('CREDENTIALS_DIR', '/files/airflow-breeze-config/keys') +WASB_DEFAULT_KEY = 'wasb_key.json' +CREDENTIALS_PATH = os.path.join(CREDENTIALS_DIR, WASB_DEFAULT_KEY) +FILENAME = "TEST.TXT" + Review comment: Since you are using sftp hook here, you also need a way to authenticate it just like you did for wasb by providing key json file. I get connection errors when I run the system test with : ``` pytest tests/providers/microsoft/azure/transfers/test_sftp_to_wasb_system.py --system azure -s ``` ########## File path: airflow/providers/microsoft/azure/example_dags/example_sftp_to_wasb.py ########## @@ -0,0 +1,45 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import os + +from airflow import DAG +from airflow.providers.microsoft.azure.transfers.sftp_to_wasb import SFTPToWasbOperator +from airflow.utils.dates import days_ago + +AZURE_CONTAINER_NAME = os.environ.get("AZURE_CONTAINER_NAME", "airflow") +BLOB_PREFIX = os.environ.get("AZURE_BLOB_PREFIX", "airflow") +SFTP_SRC_PATH = os.environ.get("AZURE_SFTP_SRC_PATH", "test-sftp-azure") + +with DAG( + "example_sftp_to_wasb", + schedule_interval=None, + start_date=days_ago(1), # Override to match your needs +) as dag: + + # [START how_to_sftp_to_wasb] + transfer_files_to_azure = SFTPToWasbOperator( + task_id="transfer_files_from_sftp_to_wasb", + # SFTP args + sftp_conn_id="sftp_default", + sftp_source_path=SFTP_SRC_PATH, + # AZURE args + wasb_conn_id="wasb_default", + container_name=AZURE_CONTAINER_NAME, + blob_prefix=BLOB_PREFIX, + ) + # [END how_to_sftp_to_wasb] Review comment: Since we are using this example for system test, I'm thinking we can have more operators here to clean up. My suggestions: Have an SFTPOperator to transfer files from local to a remote server, then transfer the files to azure and finally clean up files in remote server using delete_file method of SFTPHook and azure blob storage delete operator ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
