ephraimbuddy commented on a change in pull request #14366:
URL: https://github.com/apache/airflow/pull/14366#discussion_r580799918
##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -1425,6 +1425,8 @@ components:
type: array
items:
$ref: '#/components/schemas/ConnectionCollectionItem'
+ total_entries:
+ type: integer
Review comment:
While this will work, we have a CollectionInfo component. I will suggest
we use it and expand to other Collection components that do not have
total_entries.
For the ConnectionCollection, I would suggest this:
```
ConnectionCollection:
type: object
description: Connections
allOf:
- type: object
properties:
connections:
type: array
items:
$ref: '#/components/schemas/ConnectionCollectionItem'
- $ref: '#/components/schemas/CollectionInfo'
```
This is because the CollectionInfo component explains what total_entries is
and since this change will affect many components, it's better we use the
CollectionInfo component.
You can expand this change to DAGRun, Pool, Variable etc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
