ashb commented on a change in pull request #14306:
URL: https://github.com/apache/airflow/pull/14306#discussion_r580915645
##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -377,6 +377,13 @@ paths:
parameters:
- $ref: '#/components/parameters/PageLimit'
- $ref: '#/components/parameters/PageOffset'
+ - name: only_active
+ in: query
+ schema:
+ type: boolean
+ default: true
Review comment:
This was a bug that we included non-active dags in the API results in
first place -- non-active dags can't be operated on (they likely don't exist on
the filesystem anymore), and they are essentially invisible to the rest of the
system.
My view was that most people wouldn't notice us changing this to true by
default -- for instance if we changed the query but didn't add a param to
control it would that be a breaking change?
I don't feel strongly about the default if you both think it should be False.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
