ashb commented on a change in pull request #13735:
URL: https://github.com/apache/airflow/pull/13735#discussion_r580918918
##########
File path: chart/templates/workers/worker-deployment.yaml
##########
@@ -214,6 +214,9 @@ spec:
{{- include "custom_airflow_environment" . | indent 10 }}
{{- include "standard_airflow_environment" . | indent 10 }}
{{- end }}
+{{- if .Values.workers.extraContainers }}
+{{- toYaml .Values.workers.extraContainers | nindent 8 }}
Review comment:
⚠️ Doing this with Kube executor would break things - tasks would never
complete.
If you add an extra container that has a daemon process running, then even
if the "Airflow" worker container has finished, the pod is still active as the
daemon in the other container is still up, and the pod never leaves the running
state.
We (Astro) have had to hack around this to support running Istio sidecars,
but it was not a pretty solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
