potiuk commented on a change in pull request #12677:
URL: https://github.com/apache/airflow/pull/12677#discussion_r582237915
##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -69,8 +69,8 @@ class BigQueryHook(GoogleBaseHook, DbApiHook):
conn_name_attr = 'gcp_conn_id'
default_conn_name = 'google_cloud_default'
- conn_type = 'google_cloud_platform'
- hook_name = 'Google Cloud'
+ conn_type = 'bigquery'
+ hook_name = 'BigQuery'
Review comment:
Just a comment on this one. Yeah. I wanted to avoid this change when we
switched to 2.0 (not to add backwards incompatibilities), but this change
indeed breaks the compatibility of Google Provider, so we should mention that
in the CHANGELOG @kaxil mentioned. I think however, whether this is a good time
to "merge" this change now - we are planning a bigger release of Google
Provider (3.0.0) around March/April when we will drop "backports" altogether.
We need to update dependencies and upgrade a few remaining APIs of python
libraries of Google - and such a backwards-incompatible change could be added
then.
I think if we could make this change without this breaking compatibility
now, that would be ideal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
