potiuk edited a comment on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-786135586
> Better IDE support (find usages/ refactoring / name highlighting) for users and mainters (see above for image example) There won't by any renames for those. That would further break compatibility. so making it "easier" is false sense of security when you rename > A safer interface for users who want to add custom fields to context Not really. We are not planning to add anything to the context any time soon. and even if we do it's the same for dict/field. If someone extends data class with a new field the problem is the same. > A safer way for maintainers to add new fields to context Not really. it's the same kind of problems you get. > A clean way to implement deprecation warnings with detailed warning messages about potential silent bugs We do not need deprecation warnings in case we do not change from Dict > More flexibility down the road (dataclasses are more flexible than dictionaries) This sentence is meaningless. I argue that dicts are more flexible and probably we would both be right. > A solution that is easier to maintain in the future Again - meaningless - maintenance is also to go trough the hassle of changing and informing users. > Or said another way we shouldn't optimize for airflow 2.x maintainability we should optimize for airflow maintainability. I do not agree. I carefully weighted pros/cons and as maintainer i agree with @kaxil TypedDict is much better solution and we will have no plans to change to Dataclass. You have not convinced us. > p.s. sorry for another wall of text. I guess it turns out that I'm a little passionate on this one... No problems with being passionate (I am very passionate myself as some other committers might attest to), but I think it's good to realise that passion might easily turn into obsession and be able to say 'meh'. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
