zachliu commented on pull request #14366: URL: https://github.com/apache/airflow/pull/14366#issuecomment-786845550
> > > > i had to fix a few other to make these endpoints work in my python sdk, for example, several missing `nullable` items and some missing properties like `running_slots` in `Pool` > > > > I'll create new PRs for them > > > > > > > > > Let's fix only the collection info for this PR, You can make another PR for another one. > > > And since you have added collection info to the components, you have to remove it from the 200 responses of the affected endpoints where we also have collection info right now. E.g : > > > https://github.com/apache/airflow/blob/11d03d2f63d88a284d6aaded5f9ab6642a60561b/airflow/api_connexion/openapi/v1.yaml#L270-L271 > > > > > > You have to remove CollectionInfo here since it's already part of the other component > > > > > > ha, i actually removed them long ago since they never worked with the openapi python generator > > but someone here told me not to update them since other generator may need them. See [here](https://github.com/PolideaInternal/airflow/blob/75b0ad0fb606cc41f9af43cb6373aed25a8fc39c/openapi.yaml). > > You have to remove it. The total entries is now inside the ConnectionCollection component. Without removing it here, there tests will not pass happy to :grin: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
