dstandish commented on a change in pull request #14492: URL: https://github.com/apache/airflow/pull/14492#discussion_r584225044
########## File path: airflow/providers/airbyte/hooks/airbyte.py ########## @@ -0,0 +1,92 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import time +from typing import Optional + +from airflow.exceptions import AirflowException +from airflow.providers.http.hooks.http import HttpHook + + +class AirbyteJobController: + """Airbyte job status""" + + RUNNING = "running" + SUCCEEDED = "succeeded" + CANCELLED = "canceled" + PENDING = "pending" + FAILED = "failed" + ERROR = "error" + + +class AirbyteHook(HttpHook, AirbyteJobController): + """Hook for Airbyte API""" + + def __init__(self, airbyte_conn_id: str) -> None: + super().__init__(http_conn_id=airbyte_conn_id) + + def wait_for_job(self, job_id: str, wait_time: int = 3, timeout: Optional[int] = None) -> None: Review comment: Very generous of you to share so many examples -- thank you. > I'm personally leaning to op >> sensor approach but many users want to do "atomic" operations Before airflow 2.0, I was really not a big fan of the op >> sensor approach. The task latency bothered me and I tended to try to combine more operations into a single operator. (and this approach still has some appeal for me ) but with 2.0 and specifically the improved scheduler, there's definitely not as much reason to do so, and having the separation becomes relatively more compelling. Although then you have the issue of coordination (e.g. xcom keys...) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
