mik-laj commented on a change in pull request #14490:
URL: https://github.com/apache/airflow/pull/14490#discussion_r584433963



##########
File path: tests/api_connexion/schemas/test_dag_schema.py
##########
@@ -122,11 +123,11 @@ def test_serialize(self):
             'is_paused': None,
             'is_subdag': False,
             'orientation': 'LR',
-            'owners': [],
+            'owner': '',
             'params': {'foo': 1},
             'schedule_interval': {'__type': 'TimeDelta', 'days': 1, 'seconds': 
0, 'microseconds': 0},
             'start_date': '2020-06-19T00:00:00+00:00',
-            'tags': None,
+            'tags': ["example1", "example2"],

Review comment:
       We should return objects to make it more future-proof and extensible. 
for example, if we want to add a color, we can do so without breaking changes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to