marcosmarxm commented on a change in pull request #14492: URL: https://github.com/apache/airflow/pull/14492#discussion_r584633201
########## File path: airflow/providers/airbyte/operators/airbyte.py ########## @@ -0,0 +1,66 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from typing import Optional + +from airflow.models import BaseOperator +from airflow.providers.airbyte.hooks.airbyte import AirbyteHook +from airflow.utils.decorators import apply_defaults + + +class AirbyteTriggerSyncOperator(BaseOperator): + """ + This operator allows you to submit a job to an Airbyte server to run a integration + process between your source and destination. + + :param airbyte_conn_id: Required. The name of the Airbyte connection to use + :type airbyte_conn_id: str + :param connection_id: Required. The Airbyte ConnectionId UUID between a source and destination + :type connection_id: str + + :param timeout: Optional. The amount of time, in seconds, to wait for the request to complete. + :type timeout: float + """ + + @apply_defaults + def __init__( + self, + airbyte_conn_id: str, + connection_id: str, + asynchronous: bool = False, + api_version: str = "v1", + timeout: Optional[float] = 3600, + **kwargs, + ) -> None: + super().__init__(**kwargs) + self.airbyte_conn_id = airbyte_conn_id + self.connection_id = connection_id + self.timeout = timeout + self.api_version = api_version + self.asynchronous = asynchronous + + def execute(self, context) -> None: + """Create Airbyte Job and wait to finish""" + hook = AirbyteHook(airbyte_conn_id=self.airbyte_conn_id, api_version=self.api_version) + job_object = hook.submit_sync_connection(connection_id=self.connection_id) Review comment: It will trigger a new job to the connection. This will cause Airbyte to fetch new data. Airbyte is currently unable to guarantee idempotency through the API. But I already raised the case of being able to send other parameters and the problem of being idempotent. The user will need to guarantee idempotency through the construction of the DAG. Does writing this explicit in the documentation? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
