Fokko commented on a change in pull request #5004: [AIRFLOW-4187]
SlackWebhookOperator do not pass http_conn_id to its parent class
URL: https://github.com/apache/airflow/pull/5004#discussion_r271194784
##########
File path: tests/contrib/hooks/test_slack_webhook_hook.py
##########
@@ -91,6 +92,16 @@ def test_build_slack_message(self):
# Then
self.assertEqual(self.expected_message, message)
+ def test_get_base_url_default(self):
+ hook = SlackWebhookHook(http_conn_id='http_default')
+ hook.get_conn()
+
+ self.assertEqual(hook._get_base_url(), 'https://www.google.com/')
Review comment:
I think the question is, do we ever want to set it to something different
than `https://hooks.slack.com/services/`? I searched maybe for sandboxing, but
couldn't find it that quickly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
