kaxil commented on a change in pull request #14508:
URL: https://github.com/apache/airflow/pull/14508#discussion_r585997750
##########
File path: dev/provider_packages/prepare_provider_packages.py
##########
@@ -438,7 +445,7 @@ def is_from_the_expected_base_package(the_class: Type,
expected_package: str) ->
return the_class.__module__.startswith(expected_package)
-def inherits_from(the_class: Type, expected_ancestor: Type) -> bool:
+def inherits_from(the_class: Type, expected_ancestor: Optional[Type]) -> bool:
Review comment:
should we have the default value as `None` too since it is `Optional`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
