potiuk commented on a change in pull request #14531:
URL: https://github.com/apache/airflow/pull/14531#discussion_r586059754
##########
File path: tests/www/test_views.py
##########
@@ -1154,6 +1154,11 @@ def test_page_instance_name_xss_prevention(self):
class TestConfigurationView(TestBase):
+ def setUp(self):
+ super().setUp()
+ with mock.patch.dict(os.environ, {"AIRFLOW__CORE__UNIT_TEST_MODE":
"False"}):
+ initialize_config()
Review comment:
Yes. Otherwise one of the WWW tests fail when WWW is run in full
isolation. This test is written with the assumption that the config is created
but if it is run in isolation, the config does not exist. This is fix to those
tests - making sure that those tests do not rely on side effect from other
tests (this configuration file is written by other tests that's why it has
never been caught before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
