dstandish commented on a change in pull request #14492: URL: https://github.com/apache/airflow/pull/14492#discussion_r586538602
########## File path: airflow/providers/airbyte/operators/airbyte.py ########## @@ -0,0 +1,83 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from typing import Optional + +from airflow.exceptions import AirflowException +from airflow.models import BaseOperator +from airflow.providers.airbyte.hooks.airbyte import AirbyteHook +from airflow.utils.decorators import apply_defaults + + +class AirbyteTriggerSyncOperator(BaseOperator): + """ + This operator allows you to submit a job to an Airbyte server to run a integration + process between your source and destination. + + .. seealso:: + For more information on how to use this operator, take a look at the guide: + :ref:`howto/operator:AirbyteTriggerSyncOperator` + + :param airbyte_conn_id: Required. The name of the Airflow connection to get connection + information for Airbyte. + :type airbyte_conn_id: str + :param connection_id: Required. The Airbyte ConnectionId UUID between a source and destination. + :type connection_id: str + :param asynchronous: Optional. Flag to get job_id after submitting the job to the Airbyte API. + :type asynchronous: bool + :param api_version: Optional. Airbyte API version. + :type api_version: str + :param timeout: Optional. The amount of time, in seconds, to wait for the request to complete. + :type timeout: float + """ + + template_fields = ('connection_id',) + + @apply_defaults + def __init__( + self, + connection_id: str, + airbyte_conn_id: str = "default_airbyte_conn", + asynchronous: Optional[bool] = False, + api_version: Optional[str] = "v1", + timeout: Optional[float] = 3600, + **kwargs, + ) -> None: + super().__init__(**kwargs) + self.airbyte_conn_id = airbyte_conn_id + self.connection_id = connection_id + self.timeout = timeout + self.api_version = api_version + self.asynchronous = asynchronous + + def execute(self, context) -> None: + """Create Airbyte Job and wait to finish""" + hook = AirbyteHook(airbyte_conn_id=self.airbyte_conn_id, api_version=self.api_version) + job_object = hook.submit_sync_connection(connection_id=self.connection_id) + job_id = job_object.json().get('job').get('id') + if not job_id: Review comment: yeah i mean i think eiher approach is fine if i were doing it maybe i'd use `[]` because it's less code and does the same thing (and it doesn't cause people to double check the logic ;) ). but yeah either way fine with me! _(after mik-laj brought it up i just wanted to chime in with agreement.... i had noticed all the usage of `get` too in my first round of review but did not mention it because it doesn't make too much difference)_ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
