kenfinster commented on a change in pull request #14588:
URL: https://github.com/apache/airflow/pull/14588#discussion_r587243479



##########
File path: airflow/upgrade/rules/custom_operator_metaclass_rule.py
##########
@@ -17,6 +17,7 @@
 
 from __future__ import absolute_import
 
+from airflow import conf

Review comment:
       What is the difference?
   This is an example of rule that use it as I did:
   
https://github.com/apache/airflow/blob/v1-10-stable/airflow/upgrade/rules/import_changes.py#L24
   
   This is an example of rule that use it as you suggest:
   
https://github.com/apache/airflow/blob/v1-10-stable/airflow/upgrade/rules/hostname_callable_rule.py#L20




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to