ephraimbuddy commented on pull request #14219: URL: https://github.com/apache/airflow/pull/14219#issuecomment-790682313
Can someone review the authentication once more? I feel it's OK now except for the user data schemas. The way I was writing the schemas before was to emulate how it is as SQLAlchemy model with the consciousness that those schemas can be used in other endpoints e.g Role listing, adding, and updating, same with User endpoints=> Lists, Add, Edit etc. That made me to map them out as RoleCollectionItem(for adding and updating role endpoints), RoleCollection(for listing all roles), UserCollectionItem(for dumping user info), User(with sensitive data for creating new user), UserCollections(for get users endpoint), etc. But I think it can be modified when we work on those endpoints So, I have modified the schemas with only the things necessary for this authentication and also added @jhtimmins suggestion of using Action in place of Permission, Resource in place of View_Menu. Please take a look. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
