xinbinhuang commented on a change in pull request #14640:
URL: https://github.com/apache/airflow/pull/14640#discussion_r588860807
##########
File path: airflow/sensors/external_task.py
##########
@@ -134,20 +146,23 @@ def __init__(
self.execution_delta = execution_delta
self.execution_date_fn = execution_date_fn
self.external_dag_id = external_dag_id
+ self.external_task_group_id = external_task_group_id
self.external_task_id = external_task_id
self.check_existence = check_existence
Review comment:
`self.check_existence = check_existence` is `False` by default, which
maybe make sense for external_dag or external_task. But external_task_group has
to check and get an existing dag in order to get the list of task_ids.
I wonder if we can change the default to True or even have `check_existence`
enabled required? This can give more useful errors if the external task/dag
does not exist as well as having a consistent behavior as external_task_group.
Also, what would be use case to have a Sensor waiting for an object that
doesn't exist until it times out?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
