ashb commented on a change in pull request #14028:
URL: https://github.com/apache/airflow/pull/14028#discussion_r589511188
##########
File path: airflow/providers/ssh/hooks/ssh.py
##########
@@ -131,9 +132,11 @@ def __init__( # pylint: disable=too-many-statements
self.key_file = extra_options.get("key_file")
private_key = extra_options.get('private_key')
- private_key_passphrase =
extra_options.get('private_key_passphrase')
+ self.private_key_passphrase =
extra_options.get('private_key_passphrase')
Review comment:
Making this an instance variable has no effect -- changing it won't do
anything as the value has already been used by the time anything else could set
this.
##########
File path: airflow/providers/sftp/hooks/sftp.py
##########
@@ -76,8 +75,6 @@ def __init__(self, ftp_conn_id: str = 'sftp_default', *args,
**kwargs) -> None:
conn = self.get_connection(self.ssh_conn_id)
if conn.extra is not None:
extra_options = conn.extra_dejson
- if 'private_key_pass' in extra_options:
- self.private_key_pass =
extra_options.get('private_key_pass')
Review comment:
This makes this PR a breaking change -- could you please add a
back-compatiblity path in (i.e. something that notices when this option is set
but the new one is not, uses it and issues a deprecation warning)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
