sunkickr edited a comment on pull request #14631:
URL: https://github.com/apache/airflow/pull/14631#issuecomment-794039212
> > We should not suggest to save secrets in extra field if it's not
encrypted.
> > We have the same issue with Salesforce #8766
>
> I don't think there is anything sensitive in the extra field here, is
there @eladkal?
>
> ```
> account = conn.extra_dejson.get('extra__snowflake__account', '')
> warehouse = conn.extra_dejson.get('extra__snowflake__warehouse',
'')
> database = conn.extra_dejson.get('extra__snowflake__database', '')
> region = conn.extra_dejson.get('extra__snowflake__region', '')
> ```
>
> Those all seem safe.
This may be the code that @eladkal is worried about
https://github.com/apache/airflow/blob/99aab051600715a1ad029ce45a197a8492e5a151/airflow/providers/snowflake/hooks/snowflake.py#L136-L139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
