kaxil opened a new pull request #14710:
URL: https://github.com/apache/airflow/pull/14710


   Turns out #14698 did not fix the issue as Master failed again. After
   digging a bit more I found that the CVE was fixed in all
   Python versions: 3.6.13, 3.7.10 & 3.8.8
   
   The solution in this PR/commit checks the `parse_qsl` behavior with
   following tests:
   
   ```
   ❯ docker run -it python:3.8-slim bash
   root@41120dfd035e:/# python
   Python 3.8.8 (default, Feb 19 2021, 18:07:06)
   >>> from urllib.parse import parse_qsl
   >>> parse_qsl(";a=b")
   [(';a', 'b')]
   >>>
   
   ```
   ❯ docker run -it python:3.8.7-slim bash
   root@68e527725610:/# python
   Python 3.8.7 (default, Feb  9 2021, 08:21:15)
   >>> from urllib.parse import parse_qsl
   >>> parse_qsl(";a=b")
   [('a', 'b')]
   >>>
   ```
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to