ashb commented on a change in pull request #14709: URL: https://github.com/apache/airflow/pull/14709#discussion_r592203963
########## File path: airflow/decorators/base.py ########## @@ -0,0 +1,191 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import functools +import inspect +import re +from inspect import signature +from typing import Any, Callable, Dict, Optional, Tuple, TypeVar, cast + +from airflow.exceptions import AirflowException +from airflow.models import BaseOperator +from airflow.models.dag import DAG, DagContext +from airflow.models.xcom_arg import XComArg +from airflow.utils.decorators import apply_defaults +from airflow.utils.task_group import TaskGroup, TaskGroupContext + + +class _BaseDecoratedOperator(BaseOperator): Review comment: If this is intended to be used by others it should be `BaseDeocratedOperator` ########## File path: airflow/decorators/__init__.py ########## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. Review comment: There is an `airflow/decorators.py` that needs to be removed and the content placed in here. Having both these files is going to not behave right. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
