sunkickr opened a new pull request #14724:
URL: https://github.com/apache/airflow/pull/14724
Adds form fields and custom form behavior for the Snowflake connection so it
is more obvious to new users what fields need to be filled out. Also the
doc_strings for the hook are updated to reflect the params along with helpful
information using sphinx directives. I have categorized the fields below to
explain the change.
Fields/inputs Used by the average user
Conn Id
Conn Type
Host
Schema
Login
Password
account
database
region
Fields/inputs not used by user
Port
Fields/inputs not used by user but reflected in code(not used by average
user)
role
authenticator
private_key_field
session_parameters
aws_access_key_id
aws_secret_access_key(secret)
Proposal
- Add fields used by the average user, remove fields not used by the users,
and allow users to use extras for fields that are not used by average user
unless the input is a secret because of #8766
- Add fields for `aws_accces_key_id` and `aws_secret_access_key` because aws
secret key is a secret
- Add placeholders so users have a little more information on fields
ex. Login: "your snowflake username"
screenshot:
Ideally `aws_accces_key_id` and `aws_secret_access_key` would be stored in
Extra because they are not used by the average user. A feature in the UI that
allows users to obfuscate the Extra field is needed for secretes to be stored
there.
This PR is related to
https://github.com/apache/airflow/pull/14631#event-4445426662 where something
went wrong during rebase and the PR closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
