turbaszek commented on a change in pull request #390:
URL: https://github.com/apache/airflow-site/pull/390#discussion_r593914447



##########
File path: landing-pages/site/content/en/ecosystem/_index.md
##########
@@ -86,3 +86,5 @@ If you would you like to be included on this page, please 
reach out to the [Apac
 [Pylint-Airflow](https://github.com/BasPH/pylint-airflow) - A Pylint plugin 
for static code analysis on Airflow code.
 
 [whirl](https://github.com/godatadriven/whirl) - Fast iterative local 
development and testing of Apache Airflow workflows.
+
+[simple-dag-editor](https://github.com/ohadmata/simple-dag-editor) - Zero 
configuration Airflow plugin that let you manage your DAG files.

Review comment:
       @ohadmata thanks for explanation!
   
   > The plugin just edit the DAG file itself, it's not related to the Airflow 
executors.
   
   It's important point to me. In most production deployments DAGs are either 
synchronised from external source (repository, bucket, etc). So my question is 
what will happen when users edit the DAG via the plugin? Will this change be 
overridden by some synchronisation proces?
   
   > The plugin is designed for managing dag files that mounted to the 
airflow-webserver at "dag_folder".
   
   Will this work with CeleryExecutor where webserver and workers are on 
separate nodes (pods, VMs etc) and do not share same volume (each node has it 
own volume which is synchronised with for example S3 bucket)?
   
   As a user I miss answers to these questions. So I think it would be a good 
idea to add some explanation in documentation of your plugin so users are aware 
of some potential limitations or required setup of their deployment.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to