ecerulm commented on pull request #14607: URL: https://github.com/apache/airflow/pull/14607#issuecomment-799214227
@ecerulm , I think the user story goes more like this 1. They run `airflow plugins` and they don't see any errors, they see just `No plugins loaded` or a list of loaded plugins without the plugin they are looking for 2. They don't know that they should use `--verbose` to see errors, because in every other piece of software that they use error are always printed, and they associate `--verbose` with "enable debug logs" not with "put this if you want to see any errors". I guess it's a matter of taste, I'm confused by seeing just "No plugins loaded", to me it meant I must have put the file in the wrong directory because it's not even trying to load it. I think the experience for users trying to write or install their first plugin would be confusing. >The main reason behind introducing this errors suppression (in general) was to make the command more clearer and easier to parse using tools like jq (by using -o json). `airflow plugins -o json` output is `No plugins loaded` which is not valid JSON, should I report that as an issue? If you want to keep the current behaviour (no logs whatsoever, unless `--verbose`) then I suggest any of these other changes (I can PR if you want) : * Change the `No plugins loaded` to `No plugins loaded (3 failed loading, run with --verbose to see the actual errors)`. Embed this in each output format * Disable logs only if output != plain ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
