potiuk commented on pull request #14792: URL: https://github.com/apache/airflow/pull/14792#issuecomment-799809668
Yep. the `__del__` method is mostly about reference counting and as long as it is safe to use it in prod, It makes it easier for tests to automtically finalized it. @ashb I have not added executor to del for now - I want to keep this change localized to just make sure that SchedulerJobs are cleaned up when reference counting goes to 0 ( and I want to make sure it actually will happen) I keep the old "test" change handy in case we find that flakiness of tests is - for whatever reason not handled by the destructor/finalizer. I want to make sure it actually fixes the problem and when it does, I think adding executor should be the next step. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
