ashb commented on a change in pull request #14664:
URL: https://github.com/apache/airflow/pull/14664#discussion_r595049725
##########
File path: tests/test_utils/fab_utils.py
##########
@@ -50,7 +51,7 @@ def create_role(app, name, permissions=None):
def delete_role(app, name):
- if app.appbuilder.sm.find_role(name):
+ if app.appbuilder.sm.find_role(name) and name not in EXISTING_ROLES:
Review comment:
Ditto
```suggestion
if app.appbuilder.sm.find_role(name):
```
##########
File path: tests/test_utils/api_connexion_utils.py
##########
@@ -49,16 +50,17 @@ def create_role(app, name, permissions=None):
def delete_role(app, name):
- if app.appbuilder.sm.find_role(name):
+ if app.appbuilder.sm.find_role(name) and name not in EXISTING_ROLES:
Review comment:
With the change on L60 we don't need this too.
```suggestion
if app.appbuilder.sm.find_role(name):
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
