potiuk commented on pull request #14792: URL: https://github.com/apache/airflow/pull/14792#issuecomment-800262758
Hey @kaxil There were very tiny changes needed (maybe not entirely needed but I think make it more predictable during tests) if you can take a look: https://github.com/apache/airflow/commit/49910097ec88fd4298bc5fe8c9e14d3cbc8f13eb This change is more "predictable" when it comes to potential time-skew in case DB time is slightly different than python time (should not happen in tests but it also avoids some extra checks. * The check `min_update_interval` was for `None` which I believe was not possible to set via `int` config. And it avoids an unnecessary query. * Similarly additional ==0 explicitly in `min_serialized_dag_fetch_secs == 0`. If you think those make sense I will continue testing this evening and try to work out all the small things. I will also add the intervals to 0 in all relevant tests to make them predictable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
