uranusjr opened a new pull request #14863:
URL: https://github.com/apache/airflow/pull/14863


   A follow-up to #14746, this applies a similar approach to convert tests to 
use Pytest fixtures.
   
   I managed to make all but one test to work. The one failure (marked as xfail 
for now) is `TestAirflowBaseViews::test_index`; somehow my conversion makes the 
index page to only use 8 queries instead of the previous 43. I couldn’t figure 
out what caused the change and would be happy for any insights.
   
   The change does not produce any measuable time difference from my 
benchmarks, which is kind of expected since I mostly performed one-to-one 
conversion from `setUpClass` to `scope="class"` and `setUp` to 
`scope="function"`. I intend to go through the changes and try to locate any 
possible optimisations, but it seems the tests did not re-create expensive 
resources repeated to begin with.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to