[GitHub] [airflow] JavierLopezT commented on a change in pull request #14853: Improvements on "DAGs and Tasks documentation"

Thu, 18 Mar 2021 04:59:08 -0700 


JavierLopezT commented on a change in pull request #14853:
URL: https://github.com/apache/airflow/pull/14853#discussion_r596802290



##########
File path: airflow/example_dags/tutorial.py
##########
@@ -89,18 +89,27 @@
     # [END basic_task]
 
     # [START documentation]
-    dag.doc_md = __doc__
+    with DAG('tutorial',
+        default_args=default_args,
+        schedule_interval=timedelta(days=1)
+    ) as dag:

Review comment:
       Because of this: 
https://github.com/apache/airflow/pull/14853#issuecomment-801212303
   
   If you go directly to the section, you see this
   ![Captura de pantalla 2021-03-18 a las 12 57 
50](https://user-images.githubusercontent.com/11339132/111622488-8d23de80-87e9-11eb-95c0-a7ee6a34bbb2.png)
   
   And I think it would be more useful to have those lines in the context of an 
entire DAG. So if the tutorial dag must run fine, I think it would be better to 
include the code as text or in some other file 
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to