houqp commented on pull request #2:
URL: 
https://github.com/apache/airflow-client-python/pull/2#issuecomment-802905400


   How about following the same pattern that kubernetes adopts, i.e. turning 
the generated code into a real python submodule by manually crafting our own 
setup.py file? Something like this: 
https://github.com/kubernetes-client/python/blob/master/setup.py. This design 
allows us to control package dependency and all the pypi metadata. It also 
makes it easy for us to inject other helper submodules into the same package 
namespace, for example, kubernetes client maintains their own `config` module 
to customize how users can configure the generated python client. To implement 
the same pattern, we would need to change the python code gen script to 
generate the client using name `client` not `airflow_client`. Then we can name 
the outer package `airflow_client` and import the generated client using 
`airflow_client.client`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to