samwedge commented on pull request #14795: URL: https://github.com/apache/airflow/pull/14795#issuecomment-802934319
Thanks. I agree if we can get a nice generic test in place that doesn't have any implementation detail, then it's worth adding in. That said, I've been looking at where to make the change. My first thought was in `test_kubernetes_executor` as this is the executor we have changed. But really, the bug only shows itself when calling `SchedulerJob.adopt_or_reset_orphaned_tasks()`. Adding a test here means setting up a `KubernetesExecutor` with a lot of mocking/patching. And I'm not sure this is the best place for it. Alternatively, do you think this is a candidate for a system test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
