Fokko commented on a change in pull request #5035: [AIRFLOW-4239] Synchronize 
airflow execution timeout and aws batch job timeout
URL: https://github.com/apache/airflow/pull/5035#discussion_r272560358
 
 

 ##########
 File path: airflow/contrib/operators/awsbatch_operator.py
 ##########
 @@ -75,7 +76,7 @@ def __init__(self, job_name, job_definition, job_queue, 
overrides, max_retries=4
         self.job_queue = job_queue
         self.overrides = overrides
         self.max_retries = max_retries
-
+        self.execution_timeout = kwargs.get('execution_timeout', 
timedelta(seconds=3600))
 
 Review comment:
   I would suggest not pulling this from the `kwargs` and make it an argument 
with a default value. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to