Fokko commented on a change in pull request #4880: [AIRFLOW-3735] Separate dag 
parsing from checking
URL: https://github.com/apache/airflow/pull/4880#discussion_r272567248
 
 

 ##########
 File path: airflow/utils/dag_processing.py
 ##########
 @@ -1309,3 +1315,81 @@ def end(self):
                     self.log.info("Killing child PID: %s", child.pid)
                     child.kill()
                     child.wait()
+
+
+def process_dag_file(filepath, safe_mode=True):
 
 Review comment:
   Personally, I'm not a fan of separate functions, can't we merge this into a 
class as a static method? For example the `DagFileProcessorAgent`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to