SamWheating opened a new pull request #14981:
URL: https://github.com/apache/airflow/pull/14981


   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   Operators extending the DataprocSubmitJobOperator currently infer the 
project_id from the GCP connection, which isn't always correct (for example, 
when using a service account from one Project to submit jobs to a dataproc 
cluster in a different project).
   
   In our case, this led to 404s when trying to submit jobs, as the operator 
incorrectly assumed that the dataproc cluster was in the same project as the 
service account used to submit the job. 
   
   Adding an optional override, if the project_id is left unspecified it will 
fallback to the old behaviour. 
   
   I also understand that these operators are now deprecated, so if you don't 
want to make changes to them you can close this PR. 
   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to