potiuk opened a new pull request #14998: URL: https://github.com/apache/airflow/pull/14998
When we check whether we should rebuild image, we check if the md5sum of some important files changed - which would trigger question whether to rebuild the image or not (because of changed dependencies which need to be installed). This happens for example when package.json or yarn.lock changes. Previously, all the important files had distinct names, so we stored the md5 hashes of those files with just filenames +.md5sum but they were flattened to a single directory. Unfortunately, as of #14927 (merged with failing build) we had two package.json and two yarn.locks and it caused overwriting of md5hash of one by the other. This triggered unnecessary rebuilding of the image in CI part which resulted in failure (because of Apache Beam dependency problem). This PR fixes it by adding parent directory to the name of the md5sum file (so we have www-package.json and ui-package.json) now. Those important files change very rarely so this incident should not happen again but we added some comments preventing it. <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
