uranusjr commented on a change in pull request #14990:
URL: https://github.com/apache/airflow/pull/14990#discussion_r601274447
##########
File path: airflow/utils/helpers.py
##########
@@ -22,9 +22,10 @@
from functools import reduce
from itertools import filterfalse, tee
from typing import Any, Callable, Dict, Generator, Iterable, List, Optional,
TypeVar
-from urllib import parse
+from flask import url_for
from jinja2 import Template
+from urllib import parse
Review comment:
This should be put in the block above, with other stdlib imports.
##########
File path: airflow/utils/helpers.py
##########
@@ -22,9 +22,10 @@
from functools import reduce
from itertools import filterfalse, tee
from typing import Any, Callable, Dict, Generator, Iterable, List, Optional,
TypeVar
-from urllib import parse
+from flask import url_for
from jinja2 import Template
+from urllib import parse
Review comment:
This should be in the block above, with other stdlib imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]