potiuk commented on a change in pull request #15051:
URL: https://github.com/apache/airflow/pull/15051#discussion_r602741602
##########
File path: tests/providers/amazon/aws/hooks/test_secrets_manager.py
##########
@@ -43,12 +43,17 @@ def test_get_secret_string(self):
secret_value = '{"user": "test"}'
hook = SecretsManagerHook(aws_conn_id='aws_default')
- param = {
+ create_param = {
+ 'Name': secret_name,
+ }
+
+ put_param = {
'SecretId': secret_name,
'SecretString': secret_value,
}
- hook.get_conn().put_secret_value(**param)
+ hook.get_conn().create_secret(**create_param)
Review comment:
Nice. But the whole point of those tests is to test "put_secret_value"
method really, not the "create_secret" one :). If we simplify it, we will test
different things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
