ephraimbuddy commented on a change in pull request #15002:
URL: https://github.com/apache/airflow/pull/15002#discussion_r602896567
##########
File path: tests/providers/microsoft/azure/log/test_wasb_task_handler.py
##########
@@ -98,7 +98,7 @@ def test_wasb_log_exists(self, mock_hook):
@mock.patch("airflow.providers.microsoft.azure.hooks.wasb.WasbHook")
def test_wasb_read(self, mock_hook):
- mock_hook.return_value.read_file.return_value = 'Log line'
+ mock_hook.return_value.read_file.return_value = b'Log line'
Review comment:
When we returned bytes, users complained of logs coming as single line,
see https://github.com/apache/airflow/issues/14312. I'm wondering whether your
issue has to do with something else? and you haven't said the airflow version
you saw this issue. Sorry, what I asked for was azure version...but I meant to
ask what airflow version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
