ashb commented on a change in pull request #15034:
URL: https://github.com/apache/airflow/pull/15034#discussion_r604042598
##########
File path: tests/utils/test_task_group.py
##########
@@ -525,42 +527,6 @@ def test_dag_edges():
]
-def test_duplicate_group_id():
- from airflow.exceptions import DuplicateTaskIdFound
-
- execution_date = pendulum.parse("20200101")
-
- with pytest.raises(DuplicateTaskIdFound, match=r".* 'task1' .*"):
- with DAG("test_duplicate_group_id", start_date=execution_date):
- _ = DummyOperator(task_id="task1")
- with TaskGroup("task1"):
- pass
-
- with pytest.raises(DuplicateTaskIdFound, match=r".* 'group1' .*"):
- with DAG("test_duplicate_group_id", start_date=execution_date):
- _ = DummyOperator(task_id="task1")
- with TaskGroup("group1", prefix_group_id=False):
- with TaskGroup("group1"):
- pass
-
- with pytest.raises(DuplicateTaskIdFound, match=r".* 'group1' .*"):
- with DAG("test_duplicate_group_id", start_date=execution_date):
- with TaskGroup("group1", prefix_group_id=False):
- _ = DummyOperator(task_id="group1")
-
- with pytest.raises(DuplicateTaskIdFound, match=r".*
'group1.downstream_join_id' .*"):
- with DAG("test_duplicate_group_id", start_date=execution_date):
- _ = DummyOperator(task_id="task1")
- with TaskGroup("group1"):
- _ = DummyOperator(task_id="downstream_join_id")
-
- with pytest.raises(DuplicateTaskIdFound, match=r".*
'group1.upstream_join_id' .*"):
- with DAG("test_duplicate_group_id", start_date=execution_date):
- _ = DummyOperator(task_id="task1")
- with TaskGroup("group1"):
- _ = DummyOperator(task_id="upstream_join_id")
-
-
Review comment:
I think you now want to keep this entire block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
