RosterIn commented on pull request #14388:
URL: https://github.com/apache/airflow/pull/14388#issuecomment-810201810


   @yohei1126 The failures are:
   ```
   ************* Module tests.providers.amazon.aws.hooks.test_glue
   tests/providers/amazon/aws/hooks/test_glue.py:101:44: E1101: Instance of 
'TestGlueJobHook' has no 'some_aws_regions' member; maybe 'some_aws_region'? 
(no-member)
   ```
   
   and
   
   ```
   _________________ TestGlueJobHook.test_get_or_create_glue_job 
__________________
     
     self = <tests.providers.amazon.aws.hooks.test_glue.TestGlueJobHook 
testMethod=test_get_or_create_glue_job>
     mock_get_conn = <MagicMock name='get_conn' id='140119788712848'>
     mock_get_iam_execution_role = <MagicMock name='get_iam_execution_role' 
id='140119784978248'>
     
         @mock.patch.object(AwsGlueJobHook, "get_iam_execution_role")
         @mock.patch.object(AwsGlueJobHook, "get_conn")
         def test_get_or_create_glue_job(self, mock_get_conn, 
mock_get_iam_execution_role):
             mock_get_iam_execution_role.return_value = 
mock.MagicMock(Role={'RoleName': 'my_test_role'})
             some_script = 
"s3:/glue-examples/glue-scripts/sample_aws_glue_job.py"
             some_s3_bucket = "my-includes"
         
             mock_glue_job = mock_get_conn.return_value.get_job()['Job']['Name']
             glue_job = AwsGlueJobHook(
                 job_name='aws_test_glue_job',
                 desc='This is test case job from Airflow',
                 script_location=some_script,
                 iam_role_name='my_test_role',
                 s3_bucket=some_s3_bucket,
                 region_name=self.some_aws_region,
             ).get_or_create_glue_job()
             assert glue_job == mock_glue_job
     >       assert glue_job.region_name == self.some_aws_region
     E       AssertionError: assert <MagicMock 
name='get_conn().get_job().__getitem__().__getitem__().region_name' 
id='140120564084920'> == 'us-west-2'
     E        +  where <MagicMock 
name='get_conn().get_job().__getitem__().__getitem__().region_name' 
id='140120564084920'> = <MagicMock 
name='get_conn().get_job().__getitem__().__getitem__()' 
id='140120563852120'>.region_name
     E        +  and   'us-west-2' = 
<tests.providers.amazon.aws.hooks.test_glue.TestGlueJobHook 
testMethod=test_get_or_create_glue_job>.some_aws_region
     
     tests/providers/amazon/aws/hooks/test_glue.py:75: AssertionError
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to