dungdm93 commented on a change in pull request #15187:
URL: https://github.com/apache/airflow/pull/15187#discussion_r606895250



##########
File path: scripts/ci/docker-compose/integration-trino.yml
##########
@@ -17,10 +17,10 @@
 ---
 version: "2.2"
 services:
-  presto:
-    image: apache/airflow:presto-2020.10.08
-    container_name: presto
-    hostname: presto
+  trino:
+    image: apache/airflow:trino-2021.04.04

Review comment:
       I'd like to recommend use official trino image and mount `entrypoint.sh` 
at runtime instead of build custom image:
   ```yaml
     trino:
       image: trinodb/trino:353
       entrypoint: ["/usr/local/bin/entrypoint.sh"]
       command: ["/usr/lib/trino/bin/run-trino"]
       volumes:
       - ../dockerfiles/trino/entrypoint.sh:/usr/local/bin/entrypoint.sh:ro
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to