potiuk commented on pull request #15114: URL: https://github.com/apache/airflow/pull/15114#issuecomment-813497828
One comment for the future @darwinyip @kaxil :). Not a big issue, but worth keeping in mind to always describe in the commit and comment in `setup.py` why we are adding such limits. Why? It makes it much easier to understand when to lift the limits and when to leave them in case of further changes. I am going to provide proper fix for few other packages dropping Python 3.6 binary pypi wheels in their recent release (PR is coming) but having a comment in setup.py for the pandas-gbq could be helpful for me to understand what was going on rather than guess it (It was by accident I found my changes coincided with this one). It could have saved me a few builds to find out that I should not remove this one. I thought it was added because of transitive pandas -> numpy dependencies (which dropped support for 3.6 pypi binary releases and it's easiest in our case to limit them for <3.7 rather than build them in our image (this ain't easy). It would be a bit easier if we had it in `setup.py` as comment. or the commit message (and best if it is in both). It was a bit of luck that I looked at the PR comments to find out why this was added. I will add comment in my upcoming PR explaining why we have that `<0.15.0` thingie. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
