xinbinhuang commented on a change in pull request #14640:
URL: https://github.com/apache/airflow/pull/14640#discussion_r608782468
##########
File path: airflow/sensors/external_task.py
##########
@@ -164,18 +184,23 @@ def poke(self, context, session=None):
if self.failed_states:
count_failed = self.get_count(dttm_filter, session,
self.failed_states)
- if count_failed == len(dttm_filter):
+ if count_failed > 0:
Review comment:
I don't think it's necessary more than an entry in the `UPDATING.md`. I
think the only situation where you will have multiple counts is when the
`execution_date_fn` returns more than one execution date to wait for. However,
the original behavior will get you into a weird state when only part of the TIs
fail, i.e. one fail and one succeeds, resulting in time out. IMHO, I think
this's more like a bug than intended behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
