kaxil commented on a change in pull request #15163:
URL: https://github.com/apache/airflow/pull/15163#discussion_r610939364
##########
File path: tests/providers/elasticsearch/log/test_es_task_handler.py
##########
@@ -253,7 +253,9 @@ def test_set_context_w_json_format_and_write_stdout(self):
def test_read_with_json_format(self):
ts = pendulum.now()
- formatter = logging.Formatter('[%(asctime)s] {%(filename)s:%(lineno)d}
%(levelname)s - %(message)s')
+ formatter = logging.Formatter(
+ '[%(asctime)s] {%(filename)s:%(lineno)d} %(levelname)s -
%(message)s - %(exc_text)s'
+ )
Review comment:
This test passes without the changes in
airflow/providers/elasticsearch/log/es_task_handler.py
ideally the test should fail without the actual fix in the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
