itroulli commented on a change in pull request #15194:
URL: https://github.com/apache/airflow/pull/15194#discussion_r611813906
##########
File path: airflow/models/variable.py
##########
@@ -47,12 +47,14 @@ class Variable(Base, LoggingMixin):
id = Column(Integer, primary_key=True)
key = Column(String(ID_LEN), unique=True)
_val = Column('val', Text)
+ description = Column(Text)
is_encrypted = Column(Boolean, unique=False, default=False)
- def __init__(self, key=None, val=None):
+ def __init__(self, key=None, val=None, description=None):
super().__init__()
self.key = key
self.val = val
+ self.description = description
Review comment:
@kaxil Since this is a feature only viewable/editable from the UI, what
tests would you suggest? Just including the description field in [this
line](https://github.com/apache/airflow/blob/master/tests/www/test_views.py#L275)
would suffice?
Thanks in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
