dstandish commented on a change in pull request #15266:
URL: https://github.com/apache/airflow/pull/15266#discussion_r612954376
##########
File path: airflow/providers/google/ads/transfers/ads_to_gcs.py
##########
@@ -92,6 +94,7 @@ def __init__(
page_size: int = 10000,
gzip: bool = False,
impersonation_chain: Optional[Union[str, Sequence[str]]] = None,
+ api_version: str = "v5",
Review comment:
what might be better is to make this `Optional[str] = None` (for all the
operators)
then only supply `api_version` to hook if provided
this way, when we need to increment the default version again, we only need
to do it in one place; the operators' default will always be whatever the hook
default is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
