kaxil commented on a change in pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#discussion_r614172122
##########
File path: tests/models/test_taskinstance.py
##########
@@ -2091,8 +2091,15 @@ def test_execute_queries_count(self,
expected_query_count, mark_success):
run_type=DagRunType.SCHEDULED,
session=session,
)
+ # an extra query is fired in
RenderedTaskInstanceFields.delete_old_records
+ # for other DBs. delete_old_records is called only when mark_success
is False
+ expected_query_count_based_on_db = (expected_query_count + 1,
expected_query_count)[
+ session.bind.dialect.name in ["postgresql", "sqlite", "mysql"]
+ or expected_query_count == 0
+ or mark_success
Review comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
